https://www.growthbook.io/ logo
Powered by
a

acoustic-afternoon-96978

06/15/2023, 12:36 PM
Once we upgrade to the latest version for the SDK for android, we don't get any values. we do believe it it related to proguard any help please 🙏 we are adding this rules per the documentation
Copy code
-keep class com.sdk.growthbook.** { *; }

-keepattributes *Annotation*, InnerClasses
-dontnote kotlinx.serialization.SerializationKt
-keep,includedescriptorclasses class com.sdk.growthbook.**$$serializer { *; }
-keepclassmembers class com.sdk.growthbook.** {
    *** Companion;
}
-keepclasseswithmembers class com.sdk.growthbook.** {
    kotlinx.serialization.KSerializer serializer(...);
}
it did start with v"1.1.30"
m

most-spoon-61816

06/15/2023, 3:47 PM
Hi @acoustic-afternoon-96978 It was one change related to it exactly at that version. Here is the link for the changes: may you try somehow without this changes on your side?
a

acoustic-afternoon-96978

06/15/2023, 4:22 PM
@most-spoon-61816 Hi thanks for the fast reply . I did try with the change you mentioned still same problem when enable progaurd the library don't work and return false for everything
but with v1.1.28 it is working as expected but we are gaining more APK size due to it
m

most-spoon-61816

06/15/2023, 4:36 PM
I can check tomorrow more carefully, and let you know what we may do to help you
🙏 1
a

acoustic-afternoon-96978

06/16/2023, 7:14 AM
Thanks a lot @most-spoon-61816 🙏 , I appreciate it
a

ancient-car-96302

07/07/2023, 9:32 AM
try 1.1.34 version please. We disabled minification there
a

acoustic-afternoon-96978

07/07/2023, 9:32 AM
I did try it and it is not working still for us same problem
a

ancient-car-96302

07/07/2023, 9:35 AM
Could you please provide failure message when proguard are fails?
a

acoustic-afternoon-96978

07/07/2023, 9:36 AM
the rules are not applied, always return false.
a

ancient-car-96302

07/07/2023, 9:37 AM
in 1.1.23 version it returns correct values, right?
a

acoustic-afternoon-96978

07/07/2023, 9:37 AM
1.1.28 but with this version the apk size increased as we will our CI are running out of memory as well
a

ancient-car-96302

07/07/2023, 9:40 AM
In 1.1.34 we disabled minifacation. So, with 1.1.34 it returns correct values but there is out of memory in CI, right?
a

acoustic-afternoon-96978

07/07/2023, 9:42 AM
yes
a

ancient-car-96302

07/07/2023, 9:48 AM
i see
You are using our library in your own library (not an app), right?
a

acoustic-afternoon-96978

07/07/2023, 9:58 AM
yes. we wrapped it in a module
a

ancient-car-96302

07/07/2023, 10:00 AM
is it public repository as growthbook-kotlin? can I get some info about CI?
a

acoustic-afternoon-96978

07/07/2023, 10:01 AM
it is a private repository unfortunately. what type of info and I'll try my best to answer 🙏
a

ancient-car-96302

07/07/2023, 10:04 AM
Copy code
ERROR:R8: java.lang.OutOfMemoryError: GC overhead limit exceeded
is it all? maybe heap size in your CI?
a

acoustic-afternoon-96978

07/07/2023, 10:06 AM
the heap size is
Copy code
org.gradle.jvmargs=-Xmx16g
on a 8 core linux machine on github. it was working fine if we added this in
Copy code
-keep class com.sdk.growthbook.** { *; }
in our rules. but then the sdk is failing to retrieve the data
a

ancient-car-96302

07/07/2023, 10:12 AM
which version of growthbook-kotlin you used when you added our lib first?
a

acoustic-afternoon-96978

07/07/2023, 10:12 AM
1.1.28
a

ancient-car-96302

07/07/2023, 10:40 AM
I want to discuss this case:
Copy code
-keep class com.sdk.growthbook.** { *; }
So, you have some feature. You turns feature on but, in your app false is received, right?
a

acoustic-afternoon-96978

07/07/2023, 10:41 AM
yeah, 100% of the time
a

ancient-car-96302

07/07/2023, 10:56 AM
it seems like reproduced this issue
image.png
Are you running debug or release build?
a

acoustic-afternoon-96978

07/07/2023, 11:05 AM
release builds
a

ancient-car-96302

07/07/2023, 12:11 PM
I just checked feature flags. It works when minification is disabled. It was checked in pure Android app. Maybe separate module (wrapper module as was mentioned) adds additional complexity.
Kevych Solutions team investigated how the library works with minification enabled and disabled. It was clear that with minification enabled there were troubles with serialization. We found some proguard rule to fix it. Rule works at least for us and Ahmed. @acoustic-afternoon-96978 could you please specify here if this issue is closed for now?
My pleasure
🙌 1
2 Views
Powered by