https://www.growthbook.io/ logo
Join Slack
Powered by
Once we upgrade to the latest version for the SDK ...
# give-feedback
a
Once we upgrade to the latest version for the SDK for android, we don't get any values. we do believe it it related to proguard any help please 🙏 we are adding this rules per the documentation
Copy code
-keep class com.sdk.growthbook.** { *; }

-keepattributes *Annotation*, InnerClasses
-dontnote kotlinx.serialization.SerializationKt
-keep,includedescriptorclasses class com.sdk.growthbook.**$$serializer { *; }
-keepclassmembers class com.sdk.growthbook.** {
    *** Companion;
}
-keepclasseswithmembers class com.sdk.growthbook.** {
    kotlinx.serialization.KSerializer serializer(...);
}
it did start with v"1.1.30"
m
Hi @acoustic-afternoon-96978 It was one change related to it exactly at that version. Here is the link for the changes: may you try somehow without this changes on your side?
a
@most-spoon-61816 Hi thanks for the fast reply . I did try with the change you mentioned still same problem when enable progaurd the library don't work and return false for everything
but with v1.1.28 it is working as expected but we are gaining more APK size due to it
m
I can check tomorrow more carefully, and let you know what we may do to help you
🙏 1
a
Thanks a lot @most-spoon-61816 🙏 , I appreciate it
a
try 1.1.34 version please. We disabled minification there
a
I did try it and it is not working still for us same problem
a
Could you please provide failure message when proguard are fails?
a
the rules are not applied, always return false.
a
in 1.1.23 version it returns correct values, right?
a
1.1.28 but with this version the apk size increased as we will our CI are running out of memory as well
a
In 1.1.34 we disabled minifacation. So, with 1.1.34 it returns correct values but there is out of memory in CI, right?
a
yes
a
i see
You are using our library in your own library (not an app), right?
a
yes. we wrapped it in a module
a
is it public repository as growthbook-kotlin? can I get some info about CI?
a
it is a private repository unfortunately. what type of info and I'll try my best to answer 🙏
a
Copy code
ERROR:R8: java.lang.OutOfMemoryError: GC overhead limit exceeded
is it all? maybe heap size in your CI?
a
the heap size is
Copy code
org.gradle.jvmargs=-Xmx16g
on a 8 core linux machine on github. it was working fine if we added this in
Copy code
-keep class com.sdk.growthbook.** { *; }
in our rules. but then the sdk is failing to retrieve the data
a
which version of growthbook-kotlin you used when you added our lib first?
a
1.1.28
a
I want to discuss this case:
Copy code
-keep class com.sdk.growthbook.** { *; }
So, you have some feature. You turns feature on but, in your app false is received, right?
a
yeah, 100% of the time
a
it seems like reproduced this issue
image.png
Are you running debug or release build?
a
release builds
a
I just checked feature flags. It works when minification is disabled. It was checked in pure Android app. Maybe separate module (wrapper module as was mentioned) adds additional complexity.
Kevych Solutions team investigated how the library works with minification enabled and disabled. It was clear that with minification enabled there were troubles with serialization. We found some proguard rule to fix it. Rule works at least for us and Ahmed. @acoustic-afternoon-96978 could you please specify here if this issue is closed for now?
My pleasure
🙌 1
28 Views
Open in Slack
PreviousNext
Powered by