This message was deleted.
# give-feedback
w
This message was deleted.
w
Thanks for the feedback. I'll pass it on to the team that we might want to make this red. Also perhaps we can start keeping track of what version sdk people are connecting with if we aren't already and alert people when a new one is available and warn them loudly if they are using something that is incompatible.
👌 1
And my apologies that you wasted your time figuring this out.
❤️ 1
I'm not entirely sure about making it red for everyone, because that should probably be reserved for error state - which it would not be for people on the latest sdk. But if we can tell that you are using an out of date sdk then it should indeed be red.
b
Yeah it'd be really great if it could do that. For this particular case, making the warning clearer could be fine. But with all the new things coming in the newer SDK specs, a standard approach is probably needed 🙂
w
Yes changing the copy there seems definitely reasonable. What would your suggestion be?
Or if you want to make a PR yourself I could approve.
b
Possibly more clear that if you're using a non-JS/React SDK, or an old version of the JS/React SDK, you should not enable this, as it'll break any filtering based on the attribute
👍 1
w
Thanks for your feedback. I've made a PR that should be reviewed by others and land later today. https://github.com/growthbook/growthbook/pull/1508 Again, I hope this didn't break anything for you on your live site, and I'll have a talk with the other engineers about making sure that we don't send formats down to old sdks that don't know how to handle them or other such assurances as we continue to make improvements and new capabilities.
💯 1
❤️ 1
I've talked with the other engineers. They agree this is a known problem and it is on our roadmap to make sdk updates go more smoothly.
👌 1
I just landed the better warning message. It should show to our Cloud users in about 3-4 minutes.
142 Views