https://www.growthbook.io/ logo
#contributing
Title
# contributing
h

helpful-hydrogen-62495

03/15/2022, 7:59 PM
hey guys, looks like you’re pushing some stuff rn but my features list got bugged
f

fresh-football-47124

03/15/2022, 8:00 PM
checking
f

future-teacher-7046

03/15/2022, 8:00 PM
thanks for catching. Fixing it now
πŸ™Œ 1
Looks like were adding a new rule just as we updated the data model
h

helpful-hydrogen-62495

03/15/2022, 8:20 PM
yeh i just saw for a second that there was a separate section for dev and prod override rules and then it went to white
something that a few optional operators can solve?
any ETA? was in the middle of testing a new feature πŸ˜…
f

future-teacher-7046

03/15/2022, 8:45 PM
Finishing up now, sorry
Can you try refreshing now?
h

helpful-hydrogen-62495

03/15/2022, 8:53 PM
yes was able to reload but something weird happening with my existing feature flags. when I tried to remove a prod only from the dev side, the prod table disappeared completely
and its not coming back after i reload
did it delete all of my feature flags for Prod for that rule?
it looks totally off
i’m a little scared to touch anything now
f

future-teacher-7046

03/15/2022, 8:56 PM
sorry about that. The rules are all backed up in the database, so nothing is lost. I might revert this latest commit and do more debugging
h

helpful-hydrogen-62495

03/15/2022, 8:57 PM
I think I manually restored this one that I just lost i hope
f

future-teacher-7046

03/15/2022, 9:01 PM
I found the bug when deleting rules. It's just hiding them in the UI, but they are still in the database.
h

helpful-hydrogen-62495

03/15/2022, 9:04 PM
ok just let me know what I should expect and if it’s ok to edit things again now
f

future-teacher-7046

03/15/2022, 9:04 PM
Pushing a fix now, will take 5-10 minutes to push out
h

helpful-hydrogen-62495

03/15/2022, 9:04 PM
ok
f

future-teacher-7046

03/15/2022, 9:14 PM
the missing rules should show up now. Let me know if any of the ones you manually edited are still missing anything and I can manually restore them
h

helpful-hydrogen-62495

03/15/2022, 9:17 PM
hey noticed one more weird thing β€” when I deleted a rule it turned both the DEV and the Prod switches at the top of the page off
yeh confirmed it again - i deleted an override rule and it turned the switch to OFF, per ENV
in both cases it was the last/only override rule, if that helps. perhaps you have some logic in there that says if you delete the last rule do something different
and I broke something again πŸ˜…
f

future-teacher-7046

03/15/2022, 9:24 PM
I'm fixing the toggle part now. It's another case of it showing the wrong state in the UI, even though it's right in the database.
h

helpful-hydrogen-62495

03/15/2022, 10:17 PM
my features page is still errored out
f

future-teacher-7046

03/15/2022, 10:20 PM
Still working on a permanent fix. I can manually fix the page for you in the meantime
h

helpful-hydrogen-62495

03/15/2022, 10:21 PM
please? what should I do to not screw it up again
f

future-teacher-7046

03/15/2022, 10:23 PM
The page should load now. If you can hold off adding new rules for a little bit until we fix the underlying issue.
πŸ‘ 1
h

helpful-hydrogen-62495

03/15/2022, 10:24 PM
ok will do. please let me know when I can make changes again
f

future-teacher-7046

03/15/2022, 10:24 PM
Ok, I'm getting close. Mongo decided to store the rule arrays as objects with numeric keys instead of arrays
h

helpful-hydrogen-62495

03/15/2022, 10:24 PM
noSQL = chaos πŸ™‚
f

future-teacher-7046

03/15/2022, 10:49 PM
I believe everything is working now.
h

helpful-hydrogen-62495

03/15/2022, 11:11 PM
ok gonna go in and try to break it again
πŸ™‚
happy to report that nothing broke πŸ™Œ
14 Views