https://www.growthbook.io/ logo
Join Slack
Powered by
<@U01T6HCHD0A> can you review this again i have pu...
# sdk-flutter
g
@fresh-football-47124 can you review this again i have pushed your requested changes https://github.com/alippo-com/GrowthBook-SDK-Flutter/pull/4 here.
g
Hey @fresh-football-47124. Did you get a chance to review this? All the comments were addressed here
f
let me look
I just added one text change, but looks good 👍
g
f
okay
ya, looks good from the docs point of view
g
can we go ahead now ?
f
this is your repo, right?
sure
g
this repo belongs to our org. https://github.com/alippo-com
f
👍
playing with some creative
g
This looks cool 🆒 Why not have both android and iOS mocks in the BG, as that cross compatibility is what flutter is all about
f
I was going for 'mobile' not specifically on OS
g
Yea sure. Looks good.
@fresh-football-47124 This PR is still pending. Let me know when can this be merged.
f
the one on your repo? Looks good to me
g
Sorry. Tagged in the wrong thread. Its the one on growthbook repo to update growthbook docs. https://github.com/growthbook/growthbook/pull/326
f
ok
65 Views
Open in Slack
PreviousNext
Powered by