https://www.growthbook.io/ logo
g

gifted-cat-24658

04/29/2022, 9:52 AM
@fresh-football-47124 can you review this again i have pushed your requested changes https://github.com/alippo-com/GrowthBook-SDK-Flutter/pull/4 here.
g

glamorous-florist-39551

04/30/2022, 4:36 PM
Hey @fresh-football-47124. Did you get a chance to review this? All the comments were addressed here
f

fresh-football-47124

04/30/2022, 4:36 PM
let me look
I just added one text change, but looks good 👍
g

gifted-cat-24658

04/30/2022, 5:09 PM
f

fresh-football-47124

04/30/2022, 5:10 PM
okay
ya, looks good from the docs point of view
g

gifted-cat-24658

04/30/2022, 5:11 PM
can we go ahead now ?
f

fresh-football-47124

04/30/2022, 5:11 PM
this is your repo, right?
sure
g

gifted-cat-24658

04/30/2022, 5:14 PM
this repo belongs to our org. https://github.com/alippo-com
f

fresh-football-47124

04/30/2022, 5:15 PM
👍
playing with some creative
g

glamorous-florist-39551

05/01/2022, 6:39 AM
This looks cool 🆒 Why not have both android and iOS mocks in the BG, as that cross compatibility is what flutter is all about
f

fresh-football-47124

05/01/2022, 2:19 PM
I was going for 'mobile' not specifically on OS
g

glamorous-florist-39551

05/01/2022, 3:45 PM
Yea sure. Looks good.
@fresh-football-47124 This PR is still pending. Let me know when can this be merged.
f

fresh-football-47124

05/03/2022, 7:43 AM
the one on your repo? Looks good to me
g

glamorous-florist-39551

05/03/2022, 7:45 AM
Sorry. Tagged in the wrong thread. Its the one on growthbook repo to update growthbook docs. https://github.com/growthbook/growthbook/pull/326
f

fresh-football-47124

05/03/2022, 7:46 AM
ok
2 Views