https://www.growthbook.io/ logo
#give-feedback
Title
# give-feedback
g

green-action-55238

11/02/2023, 10:42 PM
My company is using the paid version of growthbook and we discovered the js-sdk doesn’t work with esm. See https://github.com/growthbook/growthbook/issues/509 for details I opened PR #1719 to fix the issue. Please have someone review it so we can continue with our integration. Thank you!
βœ… 1
r

rhythmic-agent-34208

11/02/2023, 10:42 PM
@blue-sundown-32899 has marked the issue as closed. Reopen Issue button
b

brief-honey-45610

11/02/2023, 11:41 PM
Hi Ken, thanks for the PR! I'll ask the Engineering team to take a look.
πŸ™Œ 1
r

rhythmic-agent-34208

11/03/2023, 1:01 AM
Hi Ken, I heard back from the Engineering team and they will need to do some testing to make sure this change will work in all of the different JavaScript runtimes and versions that we support. I'll update the PR with this info as well. Thanks again for submitting the PR!
g

green-action-55238

11/03/2023, 1:02 AM
Thanks for following up!
r

rhythmic-agent-34208

11/03/2023, 3:08 PM
You're welcome πŸ˜€ I'll close this ticket now, but if you'd like to re-open for a related issue simply reply here.
g

green-action-55238

11/14/2023, 11:04 PM
Hi August, I’m following up on https://github.com/growthbook/growthbook/pull/1719. Still waiting for meaningful interaction from growthbook
b

brief-honey-45610

11/14/2023, 11:26 PM
Thank you Ken, I just tagged the engineer in the PR and also posted in our internal channel seeking approval.
πŸ™Œ 1
I apologize for the delay on this. I do know there was a lot of testing required on our side which has slowed us down with the approval to merge
r

rhythmic-agent-34208

11/15/2023, 12:00 AM
Oh yikes, I just realized that I commented on the ​*issue*​ 2 weeks ago instead of on your PR! I'm so sorry! https://github.com/growthbook/growthbook/issues/509#issuecomment-1791762276
g

green-action-55238

11/15/2023, 12:00 AM
not a problem, i saw it
πŸ‘ 1
2 Views