Any news on getting this merged so we can update o...
# ask-questionsk
kind-ambulance-75235
05/07/2024, 5:47 PMAny news on getting this merged so we can update our PHP version? https://github.com/growthbook/growthbook-php/pull/20
f
fresh-football-47124
05/08/2024, 2:51 AM
I know we discussed it - I can ask again
fresh-football-47124
05/08/2024, 2:51 AM
I think we were concerned it would have side effects for existing users
k
kind-ambulance-75235
05/08/2024, 3:03 AMno side effects, essentially a null and empty string are treated the same except in newer version of PHP the function is typed and expects a string only so it throws when it gets a null. this PR just coalesces the null to empty string which is what was kind of happening behind the scenes before so now this just makes it explicit up front.
f
fresh-football-47124
05/08/2024, 3:17 AM
I think its more the removing of the error supressing
fresh-football-47124
05/08/2024, 3:23 AM
okay, checked with the team, we're going to merge it soon
fresh-football-47124
05/08/2024, 3:25 AM
k
kind-ambulance-75235
05/08/2024, 11:33 AMThank you so much ❤️
10 Views