https://www.growthbook.io/ logo
#give-feedback
Title
# give-feedback
b

busy-horse-73824

08/03/2022, 3:06 PM
Error in Mixpanel query
message has been deleted
this is the issue
maybe should be making regexes more as
new RegExp
etc
message has been deleted
f

future-teacher-7046

08/03/2022, 3:10 PM
Yeah, doing new RegExp should fix that Mixpanel error
b

busy-horse-73824

08/03/2022, 3:17 PM
it does seem potentially a little odd to string interpolate when generating code though
might be worth considering something like:
Copy code
const data = ${JSON.stringify(data)};
at the top?
then no possibility of code injection etc
f

future-teacher-7046

08/03/2022, 3:18 PM
Yeah, we already JSON encode everything except for those regexes.
b

busy-horse-73824

08/03/2022, 3:19 PM
ahh nice
f

future-teacher-7046

08/03/2022, 3:35 PM
Thanks! I think you'll also need to update 2 unit test cases in the confusingly named
packages/back-end/test/sql.test.ts
(lines 151 and 156)
👌 1
b

busy-horse-73824

08/03/2022, 3:38 PM
Updated those, though I'm doing this directly on GH, so will have to see what the CI thinks
f

future-teacher-7046

08/03/2022, 3:43 PM
Just merged. Will take about 10 minutes to publish the new Docker build
🙌 1
b

busy-horse-73824

08/03/2022, 3:44 PM
for GB cloud, does it update automatically or there's some separate release process?
and thank you 🙂
f

future-teacher-7046

08/03/2022, 3:44 PM
Once the docker build is done, GrowthBook Cloud updates automatically
👌 1
8 Views