https://www.growthbook.io/ logo
Join Slack
Powered by
Error in Mixpanel query
# give-feedback
b
Error in Mixpanel query
message has been deleted
this is the issue
maybe should be making regexes more as 
new RegExp
etc
message has been deleted
f
Yeah, doing new RegExp should fix that Mixpanel error
b
it does seem potentially a little odd to string interpolate when generating code though
might be worth considering something like:
Copy code
const data = ${JSON.stringify(data)};
at the top?
then no possibility of code injection etc
f
Yeah, we already JSON encode everything except for those regexes.
b
ahh nice
f
Thanks! I think you'll also need to update 2 unit test cases in the confusingly named 
packages/back-end/test/sql.test.ts
(lines 151 and 156)
👌 1
b
Updated those, though I'm doing this directly on GH, so will have to see what the CI thinks
f
Just merged. Will take about 10 minutes to publish the new Docker build
🙌 1
b
for GB cloud, does it update automatically or there's some separate release process?
and thank you 🙂
f
Once the docker build is done, GrowthBook Cloud updates automatically
👌 1
66 Views
Open in Slack
PreviousNext
Powered by