Hi, team! :slightly_smiling_face: We noticed some...
# ask-questions
b
Hi, team! πŸ™‚ We noticed some behavior in remote evaluation that is not obvious to us. Features with defaultValue: false or defaultValue: 0 are not returned in the results. Code references: β€’ In the SDK (core.ts):
Copy code
on: !!value,
off: !value,
β€’ In the Proxy (index.ts):
Copy code
if (result.on || result.experiment) {
  evaluatedFeatures[key] = { defaultValue: result.value };
}
What happens: β€’ defaultValue: false β†’ not returned β€’ defaultValue: 0 β†’ not returned β€’ defaultValue: true β†’ returned β€’ defaultValue: "false" β†’ returned Because of this, we can’t tell if a feature is really disabled or if it just has a value of false or 0. Is this the expected behavior? If so, could you explain the reasoning behind it? For us this creates issues when using boolean or numeric feature flags with remote evaluation.
c
Hi @busy-window-96391. Please let us check that and we will write to you.
❀️ 1
We have checked, and it is also not returning when the value is 0 or false on our side. It looks like the problem is in the proxy.
πŸ‘€ 1
Hi @busy-window-96391. Thank you for finding that. We have reproduced the issue and are now implementing a solution. We will provide a pull request for it as soon as possible. The changes need to be made on the SDK side.
❀️ 1
Hi again. Here is a pull request on proxy. Previously, we thought it could be changed on the SDK side, but after checking, we realized that many changes would be required in the SDK and the tests started failing. So, we assume that the best approach for now is to make the change on the proxy side.
πŸ™Œ 1
Could you kindly take a look at that when you have a moment on this pull request? CC: @freezing-postman-69602 @happy-autumn-40938
h
Thanks @calm-dog-24239! A few related bugs needed to be addressed at the same time, so I've opened a comprehensive fix here: https://github.com/growthbook/growthbook-proxy/pull/96
πŸ™Œ 1
Hi @busy-window-96391, the issue should be patched on the latest remoteEval and proxy releases.
πŸ‘ 1
c
Hi @happy-autumn-40938. Thank you very much.