https://www.growthbook.io/ logo
#contributing
Title
# contributing
c

careful-planet-92513

02/23/2022, 8:52 PM
for the bigquery integration, is there a reason you're using
DATETIME
instead of
TIMESTAMP
here? we're currently needing to cast all of our timestamp columns to datetimes (not a huge deal, just a lot of boilerplate) https://github.com/growthbook/growthbook/blob/fba1913c12c41eb7e2b7f061f1e7f9184441ab98/packages/back-end/src/integrations/BigQuery.ts#L33-L35
f

future-teacher-7046

02/23/2022, 8:55 PM
No good reason. Most other data warehouses either don't have multiple data types for this, or let you compare between them. BigQuery is unusually strict in that regard. It does seem like TIMESTAMP is much more popular than DATETIME though, so it might make sense to make that an option
c

careful-planet-92513

02/23/2022, 9:25 PM
👍 makes sense to me. not a big deal in the meantime - there's an easy workaround by casting our query columns to datetime. i can add a quick note to the docs if you want
f

future-teacher-7046

03/08/2022, 1:27 AM
Following up on this. We pushed a change to support both DATETIME and TIMESTAMP data types for BigQuery, so no need to cast anymore.
c

careful-planet-92513

03/08/2022, 11:13 PM
awesome, thanks!!
14 Views