https://www.growthbook.io/ logo
#give-feedback
Title
# give-feedback
l

late-dentist-52023

03/21/2022, 11:46 PM
in the experiments query in data sources, if you end the query with a comment e.g.
Copy code
...
FROM schema.table --this is our new experiment table
update data will fail because it becomes
Copy code
...
FROM schema.table --this is our new experiment table,
and that comma is important… easy to fix, but might want to join the strings differently to protect against that
f

future-teacher-7046

03/21/2022, 11:52 PM
Hmm. Not sure why that's happening. The experiment query should be wrapped in parentheses with newlines added before and after so a comment at the end should have no effect. Do you have a full example you can share?
l

late-dentist-52023

03/21/2022, 11:54 PM
I’ll send it to you directly. The experiments can be pulled, but the update data in results is what fails.
it is actually wrapping it as
--comment),
so a newline would take care of it
f

future-teacher-7046

03/22/2022, 2:14 AM
Pushing out a fix for this now. There were actually 8 different places that were missing a newline. Thanks for finding and reporting this bug!
👍 2
8 Views